Skip to content

Conversation

@SpriteDay
Copy link
Contributor

Why?

The Fleek CLI currently fails in Windows environments because it utilizes shell commands (rm -rf, cp) and path construction logic that are not cross-platform. This prevents Windows users from building and running the CLI, leading to errors like the en.json not found error reported in issue #47

How?

This PR addresses the compatibility issues by:

  • Replacing rm -rf commands in package.json scripts with npx rimraf for OS-agnostic file deletion
  • Replacing cp commands with npx cpy-cli to ensure assets (like the locales directory) are copied correctly on all operating systems
  • Refactoring path handling in src/utils/configuration/json.ts to use Node's path.join for cross-platform-safe path construction

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • You have manually tested
  • You have provided tests

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)

Preview?

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2025

⚠️ No Changeset found

Latest commit: 1a589c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@RobertPechaCZ RobertPechaCZ merged commit 02d2785 into fleek-platform:develop Aug 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing en.json File Error When Running Fleek CLI

2 participants